Emit moveToTrash event only for the deleting user#16664
Merged
Conversation
juliusknorr
requested review from
MorrisJobke,
blizzz,
icewind1991,
rullzer and
schiessle
Member
|
don't we need the user exists check anymore when requesting the user folder instance? |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/emit-moveToTrash-limit
branch
from
70e0962 to
b1832c8
Compare
Member
Author
|
Hm I currently fail to understand why that unit test is failing with that change :/ |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
added
2. developing
Member
|
ok so the issue with the failing test is that the users storage gets initisialized thus for the final change of the lock the user mount is there. Causing the lock to be different. So assume 'testUser'
The last one fails because it wants to release the exclusive lock (which isn't there) |
skjnldsv
approved these changes
Aug 13, 2019
juliusknorr
commented
Aug 27, 2019
juliusknorr
added
3. to review
blizzz
approved these changes
Sep 6, 2019
Member
Author
|
/backport to stable16 |
Member
Author
|
/backport to stable15 |
|
backport to stable16 in #17099 |
|
backport to stable15 in #17100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same issue as in #16624 which causes a huge loading time caused by iterating over all mounts for a file id for all users if getById is called on the RootFolder:
server/lib/private/Files/Node/Folder.php
Line 292 in e43b341
Since the moveToTrash event is only used in e2ee it should be fine to just check for the file in the users mount who is trying to delete the file.